test/integration/node_pools_test.go (1)

326-359: Good test coverage for the duplicate name conflict scenario.

The test correctly verifies that duplicate names within the same cluster return a 409 Conflict. Consider adding additional test cases to ensure complete coverage of the uniqueness constraint:

1. Cross-cluster duplicate names should succeed - Verify that the same name can be used in different clusters
2. Name reuse after soft-delete - Verify that deleting a nodepool allows its name to be reused (tests the WHERE deleted_at IS NULL partial index)

These would validate both the positive and edge-case behaviors of the constraint.

pkg/db/migrations/202602111400_add_nodepool_unique_name_constraint.go (1)

8-28: Consider pre-existing duplicate data before migration.

If the database already contains duplicate (owner_id, name) pairs for active nodepools, this migration will fail. Consider adding a pre-migration check or documenting the remediation steps.

💡 Suggested improvement: Add a pre-check query

 func addNodePoolUniqueNameConstraint() *gormigrate.Migration {
 	return &gormigrate.Migration{
 		ID: "202602111400",
 		Migrate: func(tx *gorm.DB) error {
+			// Check for existing duplicates before creating the index
+			var count int64
+			checkSQL := `SELECT COUNT(*) FROM (
+				SELECT owner_id, name FROM node_pools 
+				WHERE deleted_at IS NULL 
+				GROUP BY owner_id, name HAVING COUNT(*) > 1
+			) AS duplicates`
+			if err := tx.Raw(checkSQL).Scan(&count).Error; err != nil {
+				return err
+			}
+			if count > 0 {
+				return fmt.Errorf("cannot create unique constraint: %d duplicate (owner_id, name) pairs exist", count)
+			}
+
 			// Create unique index on (owner_id, name) to prevent duplicate nodepool names within a cluster
 			createIndexSQL := "CREATE UNIQUE INDEX IF NOT EXISTS idx_node_pools_owner_name " +
 				"ON node_pools(owner_id, name) WHERE deleted_at IS NULL;"

Note: You would also need to add "fmt" to the imports.

test/integration/node_pools_test.go (1)

327-370: Optional: add a “same name, different cluster” success case.

This would prove uniqueness is scoped to the cluster, not globally.

➕ Suggested test extension

@@
 	Expect(*problemDetail.Detail).To(ContainSubstring("already exists"),
 		"Expected error detail to mention that resource already exists")
+
+	// Optional: same name should be allowed in a different cluster
+	cluster2, err := h.Factories.NewClusters(h.NewID())
+	Expect(err).NotTo(HaveOccurred())
+	resp, err = client.CreateNodePoolWithResponse(
+		ctx, cluster2.ID, openapi.CreateNodePoolJSONRequestBody(nodePoolInput), test.WithAuthToken(ctx),
+	)
+	Expect(err).NotTo(HaveOccurred())
+	Expect(resp.StatusCode()).To(Equal(http.StatusCreated))
 }